Giving the US a share in the Strait of Hormuz is not a bad idea actually. It cements our status as the police of the strait. Legally speaking, Iran does not own the Strait of Hormuz. So, we are still gaining something valuable here.
I think a 3-year halt on uranium enrichment is not bad either, if they accept it. We certainly need time to rebuild our nuclear infrastructure. Maybe not 3 years, but definitely more than a year. As long as it involves only nuclear enrichment and not other nuclear activities, it's not bad for Iran in the long run.
The issue of Iran's HEU stockpile boils down to Iran's true intentions. If we are trying to build the bomb (the intelligent choice), we should do something about it fast. We should enrich it further in any way possible.
If we do not intend to build the bomb (super stupid, in my opinion), we can put it under IAEA supervision inside Iran and even allow a small number of Americans to supervise it. Trump can pitch this as a win for the US.